Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid admission name LimitPodHardAntiAffinityTopology #58595

Merged
merged 1 commit into from
Jan 23, 2018
Merged

fix invalid admission name LimitPodHardAntiAffinityTopology #58595

merged 1 commit into from
Jan 23, 2018
+2 −2

Conversation

CaoShuFeng
Copy link
Contributor

@CaoShuFeng CaoShuFeng commented Jan 22, 2018 •
edited
Loading

@hzxuzhonghu
@sttts

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2018
@CaoShuFeng
Copy link
Contributor Author

This change breaks backwards compatibility, I think:
https://github.com/kubernetes/kubernetes/pull/58123/files#diff-20d007f77fd2e03f5b34c86b92308749R29

@hzxuzhonghu
Copy link
Member

I referenced https://kubernetes.io/docs/admin/admission-controllers/#limitpodhardantiaffinity

/lgtm

And the document need revise.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2018
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@CaoShuFeng
Copy link
Contributor Author

And the document need revise.

I think so!

@sttts
Copy link
Contributor

sttts commented Jan 22, 2018

Which name does 1.9 use?

@hzxuzhonghu
Copy link
Member

@sttts LimitPodHardAntiAffinityTopology

@sttts
Copy link
Contributor

sttts commented Jan 22, 2018

/lgtm
/approve no-issue

@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 22, 2018
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@hzxuzhonghu
Copy link
Member

this is a widespread failure today.

@hzxuzhonghu
Copy link
Member

@CaoShuFeng Just remember

kubernetes/pkg/kubeapiserver/options/plugins.go

Line 70 in ddea2dd

antiaffinity.PluginName, // LimitPodHardAntiAffinity

The annotation also need revise.

@CaoShuFeng CaoShuFeng force-pushed the LimitPodHardAntiAffinityTopology branch from 5890b53 to 2a15776 Compare January 23, 2018 02:28
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2018
@CaoShuFeng
Copy link
Contributor Author

The annotation also need revise.

Done.

@hzxuzhonghu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2018
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-unit

@deads2k
Copy link
Contributor

deads2k commented Jan 23, 2018

/approve no-issue

@deads2k
Copy link
Contributor

deads2k commented Jan 23, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoShuFeng, deads2k, hzxuzhonghu, sttts

Associated issue requirement bypassed by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 23, 2018 •
edited
Loading

@CaoShuFeng: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 2a15776 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 58595, 58689). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 26c1a3a into kubernetes:master Jan 23, 2018
@CaoShuFeng CaoShuFeng mentioned this pull request Feb 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@sttts sttts

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CaoShuFeng @hzxuzhonghu @sttts @deads2k @k8s-ci-robot @k8s-github-robot