Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cassandra example to pick up recent changes. #5857

Merged
merged 1 commit into from
Mar 24, 2015

Conversation

brendandburns
Copy link
Contributor

Also make it buildable via Maven.

@mikeln @roberthbailey

@mikeln
Copy link
Contributor

mikeln commented Mar 24, 2015

I won't be able to get to this until tonight.

@@ -23,7 +23,7 @@ desiredState:
id: cassandra
containers:
- name: cassandra
image: kubernetes/cassandra
image: kubernetes/cassandra:v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding explicit tags.

@roberthbailey
Copy link
Contributor

LGTM, so going to merge on green. @mikeln If you have any comments, please send @brendandburns and/or myself a PR to clean this up.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2015
@mikeln
Copy link
Contributor

mikeln commented Mar 24, 2015

Tested for fix of Cassandra Cluster Example Custom Seed Cores on First Node #5737
no error anymore.

LGTM

(who closes the above issue?)

@roberthbailey
Copy link
Contributor

Fixes #5737.

roberthbailey added a commit that referenced this pull request Mar 24, 2015
Update the cassandra example to pick up recent changes.
@roberthbailey roberthbailey merged commit 13429ce into kubernetes:master Mar 24, 2015
@brendandburns brendandburns deleted the cassandra branch August 7, 2015 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants