Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: delete lot's of stuff #58564

Merged
merged 8 commits into from
Feb 3, 2018
Merged

cluster: delete lot's of stuff #58564

merged 8 commits into from
Feb 3, 2018

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Jan 20, 2018 •
edited
Loading

let me know if any of this is too aggressive.

see #49213

Remove unmaintained kube-registry-proxy support from gce kube-up.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2018
@k8s-ci-robot k8s-ci-robot requested review from gmarek and jbeda January 20, 2018 05:17
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2018
@mikedanese mikedanese changed the title gce: delete opencontrail vars cluster: delete lot's of stuff Jan 20, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2018
roberthbailey
roberthbailey reviewed Jan 20, 2018
View reviewed changes
cluster/common.sh
#
# KUBE_MASTER_URL will be empty if no current-context is set, or the
# current-context user does not exist or contain a server entry.
function detect-master-from-kubeconfig() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is used somewhere in the test framework:

W0120 06:24:49.133] ./hack/ginkgo-e2e.sh: line 53: detect-master-from-kubeconfig: command not found
W0120 06:24:49.136] !!! Error in ./hack/ginkgo-e2e.sh:53
W0120 06:24:49.136]   Error in ./hack/ginkgo-e2e.sh:53. 'detect-master-from-kubeconfig' exited with status 127

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/kubernetes/blob/master/hack/ginkgo-e2e.sh#L53

@zouyee
Copy link
Member

zouyee commented Jan 20, 2018 •
edited
Loading

Since registry example is to be deleted,I will close the PR about the registry.
#57928

BTW, would you like to add a TODO list for tracking process flow about clean work?

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2018
@mikedanese mikedanese force-pushed the rm-opencontrail branch 2 times, most recently from 7c1d8f8 to 952d6b9 Compare January 20, 2018 17:41
@justinsb
Copy link
Member

e2e should be fixed by #57896

@justinsb
Copy link
Member

/retest

1 similar comment
@justinsb
Copy link
Member

/retest

@justinsb
Copy link
Member

/retest

nfs issues: #58578

@justinsb
Copy link
Member

/retest

quota limits on vpcs in new account

@justinsb
Copy link
Member

Opened #58578 to track the NFS failures.

@jbeda
Copy link
Contributor

jbeda commented Jan 22, 2018

/approve

This is why we have source control...

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 1, 2018
@mikedanese
Copy link
Member Author

/test pull-kubernetes-unit

@krousey
Copy link
Contributor

krousey commented Feb 1, 2018

/approve

@mikedanese
Copy link
Member Author

/retest

@krousey
Copy link
Contributor

krousey commented Feb 2, 2018 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbeda, krousey, mikedanese

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55439, 58564, 59028, 59169, 59259). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 636e5e0 into kubernetes:master Feb 3, 2018
@mikedanese mikedanese deleted the rm-opencontrail branch February 3, 2018 01:54
@hswong3i hswong3i mentioned this pull request Feb 4, 2018
Merged
@jbw976 jbw976 mentioned this pull request Mar 23, 2018
Merged
@champtar champtar mentioned this pull request Dec 23, 2020
Closed
chienfuchen32 pushed a commit to chienfuchen32/rook that referenced this pull request Apr 4, 2021
@travisn @chienfuchen32
ceph: update Kubernetes registry link in CephFS document
d705119 
update Kubernetes link to version 1.9.X which includes registry addon

Ref:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md
kubernetes/kubernetes#58564

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
chienfuchen32 added a commit to chienfuchen32/rook that referenced this pull request Apr 4, 2021
@chienfuchen32
ceph: update Kubernetes registry link in CephFS document
c7f1857 
Update Kubernetes link to version 1.9.X which includes registry addon.

Ref:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md
kubernetes/kubernetes#58564

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
@chienfuchen32 chienfuchen32 mentioned this pull request Apr 4, 2021
Merged
10 tasks
mergify bot pushed a commit to rook/rook that referenced this pull request Apr 14, 2021
@chienfuchen32
ceph: update Kubernetes registry link in CephFS document
c90c262 
Update Kubernetes link to version 1.9.X which includes registry addon.

Ref:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md
kubernetes/kubernetes#58564

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
(cherry picked from commit c7f1857)
mergify bot pushed a commit to rook/rook that referenced this pull request Apr 14, 2021
@chienfuchen32
ceph: update Kubernetes registry link in CephFS document
44904a5 
Update Kubernetes link to version 1.9.X which includes registry addon.

Ref:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md
kubernetes/kubernetes#58564

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
(cherry picked from commit c7f1857)
parth-gr pushed a commit to parth-gr/rook that referenced this pull request Apr 16, 2021
@chienfuchen32 @parth-gr
ceph: update Kubernetes registry link in CephFS document
7667c89 
Update Kubernetes link to version 1.9.X which includes registry addon.

Ref:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md
kubernetes/kubernetes#58564

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
subhamkrai pushed a commit to subhamkrai/rook that referenced this pull request Oct 1, 2021
@chienfuchen32 @subhamkrai
ceph: update Kubernetes registry link in CephFS document
089cbf8 
Update Kubernetes link to version 1.9.X which includes registry addon.

Ref:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md
kubernetes/kubernetes#58564

Signed-off-by: chienfuchen32 <chienfuchen32@gmail.com>
@spowelljr spowelljr mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey left review comments

@gmarek gmarek Awaiting requested review from gmarek

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@krousey krousey

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mikedanese @zouyee @justinsb @jbeda @krousey @k8s-ci-robot @k8s-github-robot @djsly @roberthbailey