Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for changing default backend and nginx container images #58542

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Adding support for changing default backend and nginx container images #58542

merged 2 commits into from
Jan 23, 2018

Conversation

hyperbolic2346
Copy link
Contributor

What this PR does / why we need it:
Adding support for changing the images used by kubernetes worker for nginx and the default backend.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/470
Special notes for your reviewer:

Release note:

Added nginx and default backend images to kubernetes-worker config.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Jan 22, 2018

/ok-to-test

flake8 has a few comments. Can you fix these please?

$ flake8 reactive/
reactive/kubernetes_worker.py:633:80: E501 line too long (80 > 79 characters)
reactive/kubernetes_worker.py:636:1: W293 blank line contains whitespace
reactive/kubernetes_worker.py:642:80: E501 line too long (90 > 79 characters)
reactive/kubernetes_worker.py:671:80: E501 line too long (81 > 79 characters)

LGTM otherwise

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2018
@hyperbolic2346
Copy link
Contributor Author

@Cynerva flake8 testing wasn't working in my environment for some reason. Fixed and fixed the issues.

@Cynerva
Copy link
Contributor

Cynerva commented Jan 22, 2018

👍 Thanks!

/approve no-issue
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, hyperbolic2346

Associated issue requirement bypassed by: Cynerva

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 58412, 56132, 58506, 58542, 58394). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f2dc1bd into kubernetes:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cynerva Cynerva

@mbruzek mbruzek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hyperbolic2346 @Cynerva @k8s-ci-robot @fejta-bot @k8s-github-robot @mbruzek