Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated priority of mirror pod by PriorityClass. #58485

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Updated priority of mirror pod by PriorityClass. #58485

merged 1 commit into from
Jan 26, 2018

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Jan 18, 2018

Signed-off-by: Da K. Ma madaxa@cn.ibm.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58471

Release note:

Updated priority of mirror pod according to PriorityClassName.

@k82cn k82cn self-assigned this Jan 18, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2018
@bsalamat
Copy link
Member

LGTM

@k82cn
Copy link
Member Author

k82cn commented Jan 19, 2018

Will remove WIP after double confirmed kubelet's behaviour and added a unit test :).

Updated priority of mirror pod by PriorityClass.
a7c62ee 
Signed-off-by: Da K. Ma <madaxa@cn.ibm.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2018
@k82cn k82cn changed the title WIP: Updated priority of mirror pod by PriorityClass. Updated priority of mirror pod by PriorityClass. Jan 22, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2018
@k82cn
Copy link
Member Author

k82cn commented Jan 22, 2018

Added UT cases, it's ready for review :).

@k82cn k82cn removed their assignment Jan 22, 2018
@k82cn
Copy link
Member Author

k82cn commented Jan 22, 2018

/assign @derekwaynecarr @bsalamat

@k82cn
Copy link
Member Author

k82cn commented Jan 22, 2018

/retest

@bsalamat
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2018
@k82cn
Copy link
Member Author

k82cn commented Jan 23, 2018

/retest

@k82cn
Copy link
Member Author

k82cn commented Jan 24, 2018

/test pull-kubernetes-e2e-kops-aws

@derekwaynecarr
Copy link
Member

LGTM

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, derekwaynecarr, k82cn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 462d9f2 into kubernetes:master Jan 26, 2018
@k82cn k82cn deleted the k8s_58471 branch January 26, 2018 23:17
@ghost
Copy link

ghost commented Jan 29, 2018

Would this be a candidate for cherry-picking to 1.9 and 1.8?

@bsalamat
Copy link
Member

This is a bug in an alpha feature, but I still think we should cherrypick it to 1.8 and 1.9.

This was referenced Jan 30, 2018
Merged
Merged
@k82cn
Copy link
Member Author

k82cn commented Jan 30, 2018

Opened related issues for cherry pick :).

k8s-github-robot pushed a commit that referenced this pull request Jan 31, 2018
Merge pull request #59016 from k82cn/automated-cherry-pick-of-#58485-…
f7c6586 
…upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #58485: Updated priority of mirror pod by PriorityClass.

Cherry pick of #58485 on release-1.8.

#58485: Updated priority of mirror pod by PriorityClass.
k8s-github-robot pushed a commit that referenced this pull request Feb 1, 2018
Merge pull request #59008 from k82cn/automated-cherry-pick-of-#58485-…
738a818 
…upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #58485: Updated priority of mirror pod by PriorityClass.

Cherry pick of #58485 on release-1.9.

#58485: Updated priority of mirror pod by PriorityClass.
@ghost ghost mentioned this pull request Mar 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Priority admission controller should resolve priority of mirror pods
5 participants
@k82cn @bsalamat @derekwaynecarr @k8s-ci-robot @k8s-github-robot