Describes addition and deletion of minions (or nodes) at run time, and some other fixes. #5847
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
| @@ -151,3 +139,56 @@ fed-minion <none> Ready | |||
| **The cluster should be running! Launch a test pod.** | |||
|
|
|||
| You should have a functional cluster, check out [101](https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/walkthrough/README.md)! | |||
|
|
|||
| **Run time addition/deletion of minions (or nodes).** | |||
There was a problem hiding this comment.
Does it really make sense to put this AFTER we say the cluster is up?
Shouldn't we remove the --machines= stuff from the controller-manager?
aveshagarwal
force-pushed
the
kubernetes-fedora-guides-minions
branch
from
1caec5e
to
2944cac
Compare
| "resources": { | ||
| "capacity": { | ||
| "cpu": 1, | ||
| "memory": 1073741824 |
There was a problem hiding this comment.
Let's not include a capacity statement. Let just the the embedded cadvisor code supply this information.
aveshagarwal
force-pushed
the
kubernetes-fedora-guides-minions
branch
from
2944cac
to
4fc2e2e
Compare
| "labels": { | ||
| "name": "fed-node-label", | ||
| }, | ||
| } |
There was a problem hiding this comment.
json is malformed
trailing ',' after the label name
trailing ',' and after the label '}'
Also whitespace seems a little nutty....
There was a problem hiding this comment.
{
"id": "fed-node",
"kind": "Minion",
"apiVersion": "v1beta1",
"labels": {
"name": "fed-node-label"
}
}
Is this ok?
Not sure which whitespace you are talking about?
Removes --machines stuff from /etc/kubernetes/controller-manager, and now no change is required in it from its default configuration. Changes terminology from kubernetes minions to kubernetes nodes. Fixes /etc/kubernetes/proxy duplication issue.
aveshagarwal
force-pushed
the
kubernetes-fedora-guides-minions
branch
from
4fc2e2e
to
8d345fc
Compare
…inions Describes addition and deletion of minions (or nodes) at run time, and some other fixes.
Describes addition and deletion of minions (or nodes) at run time by using their json representation. This update also removes changes to /etc/kubernetes/proxy as kube master is already set in /etc/kubernetes/config so those are not required.