Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added colors to output of kubectl clusterinfo #5841

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Added colors to output of kubectl clusterinfo #5841

merged 1 commit into from
Mar 24, 2015
+302 −13,787

Conversation

piosz
Copy link
Member

@piosz piosz commented Mar 24, 2015

Added warning about trailing slashes

Also I ran godeps as described at
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/development.md

This fixes #5698

@wojtek-t
Copy link
Member

Piotr - is it expected that this PR is removing 13787 lines of code?

@piosz
Copy link
Member Author

piosz commented Mar 24, 2015

@wojtek-t yes, I ran godeps which did it.

Sample output:
clusterinfo

@satnam6502
Copy link
Contributor

Thank you kindly. The output looks nice! And thanks for adding the reminder about the trailing slash which should help to avoid further confusion.

satnam6502 added a commit that referenced this pull request Mar 24, 2015
@satnam6502
Merge pull request #5841 from piosz/clusterinfo
69a6484 
Added colors to output of kubectl clusterinfo
@satnam6502 satnam6502 merged commit 69a6484 into kubernetes:master Mar 24, 2015
@piosz piosz deleted the clusterinfo branch March 27, 2015 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@satnam6502 satnam6502

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add colors to output of kubectl clusterinfo command
4 participants
@piosz @wojtek-t @satnam6502 @googlebot