Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote aggregation API to v1 #58393

Merged
merged 2 commits into from
Jan 24, 2018
Merged

promote aggregation API to v1 #58393

merged 2 commits into from
Jan 24, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 17, 2018 •
edited
Loading

Finishing kubernetes/enhancements#263 as discussed in apimachinery

The API has been available since 1.6 and beta since 1.7. Openshift has been using it for about a year and service catalog (@pmorie) and metrics server (@piosz @DirectXMan12) have both been using too. The feature and the API have both been stable over that time.

@kubernetes/sig-api-machinery-api-reviews @kubernetes/api-approvers

/assign lavalamp
/assign smarterclayton

Promoting the apiregistration.k8s.io (aggregation) to GA

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2018
@deads2k deads2k force-pushed the agg-02-ga branch 2 times, most recently from ccd2fd0 to 896db52 Compare January 17, 2018 15:14
@smarterclayton
Copy link
Contributor

No one has any last minute naming changes they want? I haven't heard any myself.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 17, 2018

No one has any last minute naming changes they want? I haven't heard any myself.

Nor have I.

@MHBauer
Copy link
Contributor

MHBauer commented Jan 18, 2018

I don't care what it's called as long as it works.

For general use and adoption there needs to be some explicit document describing support and how to set it up. Along with whatever code paths being needed are exposed. We had @DirectXMan12 set it up for us in service-catalog, so I can't comment on whether that does or does not exist outside of our repo.

We set it up once and haven't changed it. Seems to work well enough. Seems stable.

@DirectXMan12
Copy link
Contributor

agreed on the documentation front. Otherwise, huge 👍 from me.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2018
@smarterclayton
Copy link
Contributor

Week has passed, discussed in sig-api-machinery, no concrete reason to not go given, reviewers given time...

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

Associated issue: #263

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2018
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 23, 2018

/retest

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 23, 2018

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54071, 58393). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 35ed533 into kubernetes:master Jan 24, 2018
@tengqm tengqm mentioned this pull request Jan 24, 2018
Closed
2 tasks
@DirectXMan12 DirectXMan12 mentioned this pull request Feb 13, 2018
Merged
@jennybuckley jennybuckley mentioned this pull request May 16, 2018
Merged
@deads2k deads2k deleted the agg-02-ga branch July 3, 2018 18:02
This was referenced Feb 15, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @smarterclayton @MHBauer @DirectXMan12 @k8s-ci-robot @k8s-github-robot @lavalamp