Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Metrics Server memory requirement #58391

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Reduce Metrics Server memory requirement #58391

merged 1 commit into from
Jan 18, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Jan 17, 2018

What this PR does / why we need it:
Reduces memory requirements of Metrics Server.

This was tested on GCE. On 16 - node cluster with 30 user pods per node, Metrics Server consumes ~60MB of memory. For larger clusters, the base value matters even less, and the memory utilization will be lower, therefore this change is safe.

Release note:

Reduce Metrics Server memory requirement

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2018
@kawych
Copy link
Contributor Author

kawych commented Jan 17, 2018

/assign @piosz

@kawych
Copy link
Contributor Author

kawych commented Jan 18, 2018

/retest

@piosz
Copy link
Member

piosz commented Jan 18, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2018
@piosz
Copy link
Member

piosz commented Jan 18, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, piosz

Associated issue requirement bypassed by: piosz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@kawych kawych mentioned this pull request Jan 18, 2018
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit de694a8 into kubernetes:master Jan 18, 2018
k8s-github-robot pushed a commit that referenced this pull request Jan 26, 2018
Merge pull request #58453 from kawych/automated-cherry-pick-of-#58391…
f09af49 
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #58391: Reduce Metrics Server memory requirement

Cherry pick of #58391 on release-1.9.

#58391: Reduce Metrics Server memory requirement

**Release note**:
```release-note
Reduce Metrics Server memory requirement
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kawych @piosz @k8s-ci-robot @k8s-github-robot