Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump metadata proxy to v0.1.9 #58221

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Bump metadata proxy to v0.1.9 #58221

merged 1 commit into from
Jan 20, 2018

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Jan 12, 2018 •
edited
Loading

What this PR does / why we need it: Bump GCE metadata proxy to v1.9 to pick up GoogleCloudPlatform/k8s-metadata-proxy#15.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Bump GCE metadata proxy to v0.1.9 to pick up security fixes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2018
@ikehz
Copy link
Contributor Author

ikehz commented Jan 12, 2018

(These tests won't pass until GoogleCloudPlatform/k8s-metadata-proxy#16 is in & I've cut the new version.)

@zouyee
Copy link
Member

zouyee commented Jan 13, 2018

duplicate #57928

@ikehz
Copy link
Contributor Author

ikehz commented Jan 16, 2018

@zouyee, how is this a duplicate of #57928?

@ikehz
Copy link
Contributor Author

ikehz commented Jan 16, 2018

v0.1.8 is out

/retest

@ikehz
Copy link
Contributor Author

ikehz commented Jan 17, 2018

/retest

@ikehz
Copy link
Contributor Author

ikehz commented Jan 17, 2018

/retest

@cjcullen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2018
@cjcullen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@ikehz ikehz changed the title Bump metadata proxy to v0.1.8 Bump metadata proxy to v0.1.9 Jan 19, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2018
@cjcullen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjcullen, ihmccreery

Associated issue: #15

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9e72853 into kubernetes:master Jan 20, 2018
This was referenced Jan 22, 2018
Closed
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 26, 2018
Merge pull request #58622 from ihmccreery/automated-cherry-pick-of-#5…
8ae6d31 
…5813-#58104-#58221-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #55813: Add resource limits to prometheus-to-sd to guarantee qos #58104: Introduce METADATA_CONCEALMENT_NO_FIREWALL to prevent #58221: Bump metadata proxy to v1.9

Cherry pick of #55813 #58104 #58221 on release-1.9.

#55813: Add resource limits to prometheus-to-sd to guarantee qos
#58104: Introduce METADATA_CONCEALMENT_NO_FIREWALL to prevent
#58221: Bump metadata proxy to v1.9


```release-note
GCP: allow a master to not include a metadata concealment firewall rule (if it's not running the metadata proxy), and reintroduce memory limits & bump metadata proxy to v0.1.9 to pick up security fixes.
```
This was referenced Feb 22, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bowei bowei

@cjcullen cjcullen

@Q-Lee Q-Lee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ikehz @zouyee @cjcullen @fejta-bot @k8s-ci-robot @k8s-github-robot @bowei @Q-Lee