Introduced LastTerminateState to ContainerStatus #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dawn, in #4919 you said that you were going to add this to the v1beta3 api first, but in this PR you are adding it to v1beta{1,2,3} at the same time. Do we care about back-porting this feature to the older APIs? LGTM, but assigning to @bgrant0607 to take a second look at the API changes. |
|
LGTM |
|
Yes, it needs to exist in v1beta1/2 for now, since we roundtrip objects through the older API versions. |
|
backing port is just avoid unnecessary conversion logic. |
roberthbailey
added
the
lgtm
saad-ali
added a commit
that referenced
this pull request
Mar 24, 2015
Introduced LastTerminateState to ContainerStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4919
Next PR is on reporting last terminated containerStatus
cc/ @bgrant0607