Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed deprecated libvirt-coreos kube-up/ from cluster #58023

Merged
merged 1 commit into from
Jan 10, 2018
Merged

removed deprecated libvirt-coreos kube-up/ from cluster #58023

merged 1 commit into from
Jan 10, 2018

Conversation

mikedanese
Copy link
Member

This kube-up hasn't been maintained for over a year and has been deprecated for > 6 months.

see #49213

@kubernetes/sig-cluster-lifecycle-pr-reviews

Remove deprecated and unmaintained libvirt-coreos kube-up.sh.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2018
@mikedanese mikedanese assigned roberthbailey and unassigned jbeda and zmerlynn Jan 9, 2018
@roberthbailey
Copy link
Contributor

/cc @lhuard1A

@k8s-ci-robot
Copy link
Contributor

@roberthbailey: GitHub didn't allow me to request PR reviews from the following users: lhuard1A.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lhuard1A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey
Copy link
Contributor

/lgtm

We have plenty of time before 1.10 to roll this change back if we want.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2018
@jbeda
Copy link
Contributor

jbeda commented Jan 9, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbeda, mikedanese, roberthbailey

Associated issue: #49213

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57919, 58021, 58020, 58023). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 78c8249 into kubernetes:master Jan 10, 2018
@stewart-yu stewart-yu mentioned this pull request Jan 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikedanese @roberthbailey @k8s-ci-robot @jbeda @k8s-github-robot @zmerlynn