Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated openstack heat #58021

Merged
merged 1 commit into from
Jan 10, 2018
Merged

remove deprecated openstack heat #58021

merged 1 commit into from
Jan 10, 2018

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Jan 9, 2018 •
edited
Loading

this directory hasn't been touched in a year.

see #49213

@kubernetes/sig-cluster-lifecycle-pr-reviews

Remove deprecated and unmaintained openstack-heat kube-up.sh.

@mikedanese
remove deprecated openstack heat
29fa89d 
this directory hasn't been touched in a year.

see kubernetes#49213
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 9, 2018
@dims
Copy link
Member

dims commented Jan 9, 2018

/lgtm

Let's rip it out. thanks @mikedanese

cc @k8s-sig-openstack-pr-reviews

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2018
@timothysc
Copy link
Member

/cc @roberthbailey

@jbeda
Copy link
Contributor

jbeda commented Jan 9, 2018

/lgtm

1 similar comment
@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jbeda, mikedanese, roberthbailey

Associated issue: #49213

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikedanese
Copy link
Member Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57919, 58021, 58020, 58023). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit bc067f5 into kubernetes:master Jan 10, 2018
@mikedanese mikedanese deleted the rm-openstack branch January 10, 2018 01:10
@stewart-yu stewart-yu mentioned this pull request Jan 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@dims dims

@jbeda jbeda

@zmerlynn zmerlynn

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mikedanese @dims @timothysc @jbeda @roberthbailey @k8s-ci-robot @k8s-github-robot @zmerlynn