Rename the JSON for GCEPersistentDisk, fix examples #5794
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. volumes.md has an older v1beta1 GCE example. |
thockin
force-pushed
the
gcepd_name
branch
2 times, most recently
from
ca9bb16 to
5abbbac
Compare
roberthbailey
added
the
lgtm
|
LGTM. Will merge on green. |
I know the internal JSO tags are slated for death. Until then, make them correct. Also fix some examples of v1b3 conversions that did not rename the JSON field.
|
LGTM. Thanks. |
roberthbailey
added a commit
that referenced
this pull request
Mar 24, 2015
Rename the JSON for GCEPersistentDisk, fix examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the internal JSON tags are slated for death. Until then, make them
correct. Also fix some examples of v1b3 conversions that did not rename the
JSON field.