Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy_read_timeout flag to kubeapi_load_balancer charm. #57926

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Add proxy_read_timeout flag to kubeapi_load_balancer charm. #57926

merged 1 commit into from
Jan 8, 2018

Conversation

wwwtyro
Copy link
Contributor

@wwwtyro wwwtyro commented Jan 6, 2018

What this PR does / why we need it: Add proxy_read_timeout flag to kubeapi_load_balancer charm.

Release note:

Add proxy_read_timeout flag to kubeapi_load_balancer charm.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2018
@ktsakalozos
Copy link
Contributor

/approve no-issue

@ktsakalozos
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2018
@Cynerva
Copy link
Contributor

Cynerva commented Jan 8, 2018

/assign @Cynerva

@Cynerva
Copy link
Contributor

Cynerva commented Jan 8, 2018

/lgtm

👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, ktsakalozos, wwwtyro

Associated issue requirement bypassed by: ktsakalozos

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57926, 57930). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b22f829 into kubernetes:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cynerva Cynerva

@thockin thockin

@ktsakalozos ktsakalozos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wwwtyro @ktsakalozos @Cynerva @k8s-ci-robot @k8s-github-robot @thockin