Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More node describe, and 'kubectl describe' tests for all resources #5792

Merged
merged 2 commits into from
Mar 23, 2015

Conversation

ddysher
Copy link
Contributor

@ddysher ddysher commented Mar 23, 2015

No description provided.

@j3ffml
Copy link
Contributor

j3ffml commented Mar 23, 2015

LGTM. Test failures look like flakes, kicked both.

@j3ffml
Copy link
Contributor

j3ffml commented Mar 23, 2015

Integration test still failing. You may want to rebase to HEAD to pick up fix from #5775.

@ddysher
Copy link
Contributor Author

ddysher commented Mar 23, 2015

Rebased

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2015
@j3ffml
Copy link
Contributor

j3ffml commented Mar 23, 2015

lgtm. Shippable green; merging.

j3ffml added a commit that referenced this pull request Mar 23, 2015
More node describe, and 'kubectl describe' tests for all resources
@j3ffml j3ffml merged commit 7f7a004 into kubernetes:master Mar 23, 2015
@ddysher ddysher deleted the more-describe branch March 13, 2016 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/introspection lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants