Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Use existing subnetwork of ILB forwarding rule #57861

Merged
merged 1 commit into from
Jan 10, 2018
Merged

GCE: Use existing subnetwork of ILB forwarding rule #57861

merged 1 commit into from
Jan 10, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Jan 5, 2018 •
edited
Loading

Fixes #57860

Test Cases:
Clusters using auto network with existence of a manual subnet in same region.

  • Upgrade 1.7 cluster with existing ILBs to latest. Confirm existing ILBs still are synced.
    Version 1.7 does not attempt to fill in the subnetwork, so the forwarding rule was created with the correct subnetwork.
  • Upgrade 1.8 cluster with existing ILBs to latest. Confirm existing ILBs (using wrong subnet) still are synced.
  • Latest version creates ILBs using the correct subnet.

Clusters with manual subnets have always and will continue to use the subnet specified in gce.conf.

  • Upgrade 1.8 cluster with existing ILBs to latest. Confirm existing ILBs (using manual subnet) still are synced.

Clusters with legacy networks have always and will continue to use an empty subnet.

  • Upgrade 1.8 cluster with existing ILBs to latest. Confirm existing ILBs (using legacy network) still are synced.

Release note:

GCE: Allows existing internal load balancers to continue using an outdated subnetwork

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2018
@nicksardo
Copy link
Contributor Author

/assign bowei

@nicksardo nicksardo changed the title Use existing subnetwork of forwarding rule GCE: Use existing subnetwork of ILB forwarding rule Jan 5, 2018
@nicksardo
Copy link
Contributor Author

@rramkumar1

@nicksardo
Copy link
Contributor Author

Test cases passed. PTAL @rramkumar1 @bowei

@rramkumar1
Copy link
Contributor

LGTM

bowei
bowei reviewed Jan 10, 2018
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2018
@bowei
Copy link
Member

bowei commented Jan 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo

Associated issue: #57860

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@nicksardo
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54230, 58100, 57861, 54752). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8c22277 into kubernetes:master Jan 10, 2018
This was referenced Jan 10, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 11, 2018
Merge pull request #58109 from nicksardo/automated-cherry-pick-of-#57…
686a184 
…861-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #57861: Use existing subnetwork of forwarding rule

Cherry pick of #57861 on release-1.8.

#57861: Use existing subnetwork of forwarding rule

**Release note**:
```release-note
GCE: Allows existing internal load balancers to continue using an outdated subnetwork 
```
k8s-github-robot pushed a commit that referenced this pull request Jan 11, 2018
Merge pull request #58110 from nicksardo/automated-cherry-pick-of-#57…
33d8d8e 
…861-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #57861: Use existing subnetwork of forwarding rule

Cherry pick of #57861 on release-1.9.

#57861: Use existing subnetwork of forwarding rule

**Release note**:
```release-note
GCE: Allows existing internal load balancers to continue using an outdated subnetwork 
```
@nicksardo nicksardo deleted the existing-sub branch January 12, 2018 06:59
@prameshj prameshj mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksardo @rramkumar1 @bowei @k8s-ci-robot @k8s-github-robot