Add validation error explanation for long annotations. #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
added
the
lgtm
|
LGTM |
| @@ -133,8 +133,8 @@ func NewFieldNotFound(field string, value interface{}) *ValidationError { | |||
| return &ValidationError{ValidationErrorTypeNotFound, field, value, ""} | |||
| } | |||
|
|
|||
| func NewFieldTooLong(field string, value interface{}) *ValidationError { | |||
| return &ValidationError{ValidationErrorTypeTooLong, field, value, ""} | |||
| func NewFieldTooLong(field string, value interface{}, maxLength string) *ValidationError { | |||
There was a problem hiding this comment.
Why is max length a string?
There was a problem hiding this comment.
Because in the only use-case we have it also contains units (e.g. "1234 B")
|
Also, please rebase. |
fgrzadkowski
force-pushed
the
better_errors
branch
from
6be1501
to
09033e8
Compare
|
Rebased. |
fgrzadkowski
force-pushed
the
better_errors
branch
from
09033e8
to
6bc1e2e
Compare
saad-ali
added a commit
that referenced
this pull request
Mar 24, 2015
Add validation error explanation for long annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3087