Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable liveness probe initial delays for etcd and kube-apiserver in GCE #57749

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Configurable liveness probe initial delays for etcd and kube-apiserver in GCE #57749

merged 1 commit into from
Jan 2, 2018
+29 −2

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jan 2, 2018 •
edited
Loading

Release note:

Configurable liveness probe initial delays for etcd and kube-apiserver in GCE

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 2, 2018
@wojtek-t wojtek-t force-pushed the configurable_liveness_probes branch from 88fdfba to 313e585 Compare January 2, 2018 13:16
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 2, 2018

/approve no-issue

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2018
mborsz
mborsz reviewed Jan 2, 2018
View reviewed changes
cluster/saltbase/salt/etcd/etcd.manifest Outdated
@@ -22,6 +22,7 @@
{% if pillar.get('storage_backend', 'etcd3') == 'etcd3' -%}
{% set quota_bytes = '--quota-backend-bytes=4294967296' -%}
{% endif -%}
{% set liveness_probe_initial_delay = pillar.get('kube_apiserver_liveness_probe_initial_delay', 15) -%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etcd_liveness_probe_initial_delay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wojtek-t wojtek-t force-pushed the configurable_liveness_probes branch from 313e585 to c3b0a83 Compare January 2, 2018 14:10
@mborsz
Copy link
Member

mborsz commented Jan 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 2, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 2, 2018 •
edited
Loading

@wojtek-t: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit c3b0a83 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57747, 57749). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit fd90c93 into kubernetes:master Jan 2, 2018
@wojtek-t wojtek-t mentioned this pull request Jan 2, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 3, 2018
Merge pull request #57764 from wojtek-t/automated-cherry-pick-of-#577…
e4dad7f 
…49-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #57749 upstream release 1.9 

Cherry pick of #57749  on release-1.9.

#57749 : Configurable liveness probe initial delays for etcd and kube-apiserver in GCE
This was referenced Jan 3, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 3, 2018
Merge pull request #57780 from wojtek-t/automated-cherry-pick-of-#577…
df3fe3e 
…49-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #57749 upstream release 1.8 

Cherry pick of #57749 on release-1.8.

#57749 : Configurable liveness probe initial delays for etcd and kube-apiserver in GCE
k8s-github-robot pushed a commit that referenced this pull request Jan 4, 2018
Merge pull request #57781 from wojtek-t/automated-cherry-pick-of-#577…
1f3d8a0 
…49-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #57749 upstream release 1.7 

Cherry pick of #57749 on release-1.7.

#57749 : Configurable liveness probe initial delays for etcd and kube-apiserver in GCE
@wojtek-t wojtek-t deleted the configurable_liveness_probes branch February 9, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz mborsz left review comments

Assignees

@mborsz mborsz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @mborsz @k8s-ci-robot @k8s-github-robot