Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow kubectl set image/env on a cronjob #57742

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Allow kubectl set image/env on a cronjob #57742

merged 1 commit into from
Jan 4, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 2, 2018

@kubernetes/sig-cli-pr-reviews ptal

Release note:

Allow kubectl set image|env on a cronjob

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2018
@liggitt
Copy link
Member

liggitt commented Jan 4, 2018

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0b0254f into kubernetes:master Jan 4, 2018
@liggitt liggitt mentioned this pull request Jan 6, 2018
Closed
@soltysh soltysh deleted the cronjob_podspec branch January 9, 2018 16:07
@Hashfyre
Copy link

Hi, can anyone confirm if this fix is in v1.9.x

@soltysh
Copy link
Contributor Author

soltysh commented Mar 20, 2018

@Hashfyre no, it's not.

@base698
Copy link

base698 commented Jun 2, 2018

Nooooooo.

@sonu27
Copy link

sonu27 commented Jun 11, 2018 •
edited
Loading

It's in v1.10, you can manually get kubectl here https://storage.googleapis.com/kubernetes-release/release/v1.10.4/bin/darwin/amd64/kubectl

Hopefully they update cloud sdk soon

@leejones leejones mentioned this pull request Jul 27, 2018
Closed
@nobuhikosawai nobuhikosawai mentioned this pull request Jun 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@adohe-zz adohe-zz

@ericchiang ericchiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@soltysh @liggitt @k8s-ci-robot @k8s-github-robot @Hashfyre @base698 @sonu27 @adohe-zz @ericchiang