Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify bash when installing kubernetes via get.k8s.io. #5765

Merged
merged 1 commit into from
Mar 23, 2015

Conversation

roberthbailey
Copy link
Contributor

Fixes #5689.

@zmerlynn
Copy link
Member

You could go a little further and check that SHELL is bash. That's how I was considering fixing this.

(You might want to see if there's a better way to check for bash explicitly, but that's -a- way to check.)

@zmerlynn
Copy link
Member

Ah, here's an easy one:

if [ -z "${BASH_VERSION:-}" ]; then
  # error
fi

(inspired by second answer on http://stackoverflow.com/questions/3199893/howto-detect-bash-from-shell-script)

@roberthbailey
Copy link
Contributor Author

@zmerlynn - Can we check the shell in a separate PR? This change is really just to update the documentation to suggest that folks use a shell that will work with our install script.

brendandburns added a commit that referenced this pull request Mar 23, 2015
Specify bash when installing kubernetes via get.k8s.io.
@brendandburns brendandburns merged commit 7547eae into kubernetes:master Mar 23, 2015
@roberthbailey roberthbailey deleted the pipefail branch April 9, 2015 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when i run " curl -sS https://get.k8s.io | sh" ,i get error sh: 44: set: Illegal option -o pipefail
4 participants