Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor cleanups and simplifications to the ansible directions. #5760

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Some minor cleanups and simplifications to the ansible directions. #5760

merged 1 commit into from
Mar 24, 2015
+53 −24

Conversation

jayunit100
Copy link
Member

... works fabulously, btw.

roberthbailey
roberthbailey reviewed Mar 22, 2015
View reviewed changes
docs/getting-started-guides/fedora/fedora_ansible_config.md

/usr/bin/kubectl create -f apache.json

**Testing you're new kube cluster**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/you're/your

@roberthbailey
Copy link
Contributor

Some grammatical suggestions. Otherwise lgtm.

@roberthbailey roberthbailey self-assigned this Mar 22, 2015
@jayunit100 jayunit100 force-pushed the ansible-readme branch 2 times, most recently from 172c8e2 to dd9eaed Compare March 23, 2015 02:31
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@jayunit100 jayunit100 force-pushed the ansible-readme branch 2 times, most recently from 450662a to 25b99d4 Compare March 23, 2015 02:38
@googlebot
Copy link

CLAs look good, thanks!

@jayunit100
Copy link
Member Author

okay, fixed. thanks for the fast review. just some minor updates hope this helps folks using ansible.

roberthbailey
roberthbailey reviewed Mar 23, 2015
View reviewed changes
docs/getting-started-guides/fedora/fedora_ansible_config.md
```

**Tell ansible which user has ssh access (and sudo access to root)**
**Setup ansible access to youre nodes**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more.... since I can't merge until tomorrow anyway, might as well fix this one too.

s/youre/your

@jayunit100 jayunit100 force-pushed the ansible-readme branch 4 times, most recently from c5f4766 to a5b8ebf Compare March 23, 2015 18:09
@jayunit100
Copy link
Member Author

rebased and added one more detail, about how you need to check the IPs after setup.

@roberthbailey
Copy link
Contributor

LGTM. Will merge on green.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2015
@roberthbailey
Copy link
Contributor

Both travis and shippable have failed a few times in a row. I don't see how it could be related to your (documentation) change, but you may have been sync'd to an unstable commit. Could you sync to head and refresh this branch so we get a clean test run before merging?

Sorry for the trouble.

@roberthbailey
Copy link
Contributor

@jayunit100 to pick up the fixes you should sync beyond #5775.

@jayunit100
Copy link
Member Author

hmm yes maybe your right, and maybe thats whats caused other pushes of mine to fail.... okay i rebased and pushed

@roberthbailey
Copy link
Contributor

Thanks, and sorry for the hassle. I'll merge in the morning during merge hours.

@jayunit100
Copy link
Member Author

no prob ! thanks for the review.

roberthbailey added a commit that referenced this pull request Mar 24, 2015
@roberthbailey
Merge pull request #5760 from jayunit100/ansible-readme
1dc7bcf 
Some minor cleanups and simplifications to the ansible directions.
@roberthbailey roberthbailey merged commit 1dc7bcf into kubernetes:master Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayunit100 @roberthbailey @googlebot