Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup REST interfaces across the codebase #5758

Merged
merged 3 commits into from
Mar 23, 2015
Merged

Cleanup REST interfaces across the codebase #5758

merged 3 commits into from
Mar 23, 2015

Conversation

smarterclayton
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@mbforbes mbforbes added cla: yes and removed cla: no labels Mar 21, 2015
@smarterclayton smarterclayton added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 23, 2015
@derekwaynecarr
Copy link
Member

This is a nice improvement in both code structure and naming. I never liked REST* prefixes and it makes sense to put this in the rest package.

Taking this from @bgrant0607 to save him some cycles.

Will merge on green since this LGTM

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2015
@smarterclayton
Move REST* interfaces into pkg/api/rest
d46087d 
Dependency chain is now api -> api/rest -> apiserver.  Makes the
interfaces much cleaner to read, and cleans up some inconsistenties
that crept in along the way.
@smarterclayton
Remove older names
5a3f0ad
@smarterclayton
Rename NewREST -> NewStorage to align on terminology
9bb797f
@smarterclayton smarterclayton mentioned this pull request Mar 23, 2015
Merged
@derekwaynecarr
Copy link
Member

Got a green Shippable.

derekwaynecarr added a commit that referenced this pull request Mar 23, 2015
@derekwaynecarr
Merge pull request #5758 from smarterclayton/get_input_parameters
3864cad 
Cleanup REST interfaces across the codebase
@derekwaynecarr derekwaynecarr merged commit 3864cad into kubernetes:master Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smarterclayton @googlebot @derekwaynecarr @mbforbes @bgrant0607