Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS NLB delete error #57569

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Fix AWS NLB delete error #57569

merged 1 commit into from
Feb 25, 2018

Conversation

micahhausler
Copy link
Member

What this PR does / why we need it:

Fixes an error when deleting an NLB in AWS

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #57568

Special notes for your reviewer:

Release note:

Fixes an error when deleting an NLB in AWS - Fixes #57568

@justinsb How do I get this into the release-1.9 branch?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2017
@micahhausler
Copy link
Member Author

/sig aws

chrislovecnm
chrislovecnm reviewed Dec 23, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have unit test or e2e test for this?

@chrislovecnm
Copy link
Contributor

Code looks solid btw

@dims
Copy link
Member

dims commented Dec 24, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 24, 2017
@micahhausler
Copy link
Member Author

@chrislovecnm I don't have an E2E test yet. I'll be working on that next

@micahhausler
Copy link
Member Author

/cherrypick-candidate

@StevenACoffman
Copy link
Contributor

Ha! Thanks @micahhausler ! I just found this issue, went to report it, and found your solution. Very nice work!

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2018
@chrislovecnm
Copy link
Contributor

/assign @justinsb

@justinsb
Copy link
Member

/lgtm

/retry

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2018
@micahhausler
Copy link
Member Author

/retry pull-kubernetes-cross

1 similar comment
@justinsb
Copy link
Member

/retry pull-kubernetes-cross

@justinsb
Copy link
Member

Going to close & reopen to try to wake up CI

@justinsb justinsb closed this Feb 25, 2018
@justinsb justinsb reopened this Feb 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, justinsb, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d1f3de9 into kubernetes:master Feb 25, 2018
@mheese
Copy link

mheese commented Mar 24, 2018

@micahhausler @justinsb any chance that we can get this into a 1.9.x release?

@baldeynz
Copy link

Hi as per above - is this in a 1.9 release? im running 1.9.6 and seeing that the nlb's are deleted ok now but the ingress rules created for it arent cleaned up. same as https://github.com/kubernetes/kubernetes/issues/57568

@micahhausler micahhausler mentioned this pull request May 11, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 20, 2018
Merge pull request #63738 from micahhausler/automated-cherry-pick-of-…
f97ec8c 
…#57569-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #57569: Fix AWS NLB delete error

Cherry pick of #57569 on release-1.9.

#57569: Fix AWS NLB delete error
@micahhausler micahhausler deleted the nlb-remove-fix branch January 21, 2019 17:38
@gmorse-godaddy gmorse-godaddy mentioned this pull request Aug 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm left review comments

Assignees

@justinsb justinsb

@chrislovecnm chrislovecnm

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS NLB service doesn't remove Security Group rules on delete
10 participants
@micahhausler @chrislovecnm @dims @StevenACoffman @justinsb @k8s-ci-robot @k8s-github-robot @mheese @baldeynz @zmerlynn