Support multiple scale sets in Azure cloud provider #57543
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
|
@karataliu for review |
| if err := ss.updateCache(); err != nil { | ||
| glog.Errorf("updateCache failed: %v", err) | ||
| } | ||
| }, 5*time.Minute, wait.NeverStop) |
There was a problem hiding this comment.
is there any reference for this value?
| return "", cloudprovider.InstanceNotFound | ||
| scaleSetName, err := extractScaleSetNameByVMID(providerID) | ||
| if err != nil { | ||
| glog.V(4).Infof("Can not extract scale set name from providerID (%s), assuming it is mananaged by availability set", providerID) |
There was a problem hiding this comment.
Infof ? Pls print err, and it does not return err?
|
|
||
| instanceID, err := getLastSegment(providerID) | ||
| if err != nil { | ||
| glog.V(4).Infof("Can not extract instanceID from providerID (%s), assuming it is mananaged by availability set", providerID) |
|
BTW, will there be a similar implementaion of updatecache for availability set? |
availability set cache will be supported with difference ways. @karataliu is working on it. |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer Associated issue: #43287 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 57502, 57543). If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
@feiskyer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR adds multiple scale sets support in Azure cloud provider.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Continue of #43287.
Special notes for your reviewer:
Release note:
/assign @brendandburns @andyzhangx