Changing ingress from manually scaling rc to a daemon set. #57530
Conversation
k8s-ci-robot
added
release-note
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/test pull-kubernetes-bazel-test |
…e been from the beginning.
| @@ -20,6 +20,7 @@ | |||
| import shutil | |||
| import subprocess | |||
| import time | |||
| import json | |||
There was a problem hiding this comment.
This is already imported on line 17:
$ flake8 kubernetes_worker.py
kubernetes_worker.py:23:1: F811 redefinition of unused 'json' from line 17
Mind fixing that up? Our automation will fuss about it.
There was a problem hiding this comment.
Thanks for noticing that.
|
/approve no-issue Thanks for this 👍 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynerva, hyperbolic2346 Associated issue requirement bypassed by: Cynerva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 57492, 57530). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Quality of life fix. We used to set an RC to run the nginx ingress and then scale it in the charm as workers were added. Now we just use a daemon set to make sure it is running everywhere. Using application-specific names and roles so multiple applications can have different ingress settings.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/367
Special notes for your reviewer:
Release note: