Fix guestbook.sh to make it work on GKE. #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gcloud compute target-pools delete -q --region ${REGION} "${INSTANCE_PREFIX}-default-frontend" || true | ||
| gcloud compute firewall-rules delete guestbook-e2e-minion-8000 -q || true | ||
| if [[ "${KUBERNETES_PROVIDER}" == "gce" ]]; then | ||
| gcloud compute forwarding-rules delete -q --project="${PROJECT}" --region ${REGION} "${INSTANCE_PREFIX}-default-frontend" || true |
There was a problem hiding this comment.
It seems like we'd leak the forwarding rule/target pool on GKE without some cleanup here.
There was a problem hiding this comment.
Testing seems to indicate this is not needed for GKE. I'll double check.
|
Merging to let this run on jenkins a few times (to verify that it fixes GKE) before we nuke guestbook.sh. |
roberthbailey
added a commit
that referenced
this pull request
Mar 23, 2015
Fix guestbook.sh to make it work on GKE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.