Kubelet: add podManager for managing internal pod storage #5748
Conversation
|
(This is to address #5615) This PR does nothing other than moving things around. I want to get this out so that people working on kubelet (including myself) won't need to rebase so often. Following PRs will attempt to accomplish the list below:
|
|
/cc @vmarmol |
| "github.com/golang/glog" | ||
| ) | ||
|
|
||
| type podManager struct { |
There was a problem hiding this comment.
Lets make it an interface for easy mocking
There was a problem hiding this comment.
I wasn't sure if it's worth mocking pod manager at all, but I don't mind keeping the options open. Done.
|
Minor comments, looks good overall and removes over 100 lines in kubelet.go :) |
|
Uploaded a new patch (sorry I forgot to create a new commit). PTAL. |
|
Rebased. |
|
LGTM, thanks @yujuhong! |
|
The head is broken so the tests are failing. Waiting for the fix to go in. |
|
This is the second time in two days we run into this :(
|
This change moves pod array and mirrorPods into podManager, along with all methods accessing these internal pod storages. This is the first step of the refactoring, and no function change is involved.
|
I rebased and uploaded again. travis already passed once. |
|
Ping! This is ready to merge :) |
|
LGTM, merging thanks @yujuhong! |
Kubelet: add podManager for managing internal pod storage
This change moves pod array and mirrorPods into podManager, along with all
methods accessing these internal pod storage. This is the first step of the
refactoring, and no function change is involved.