Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #57252: Reduce CPU and memory requests for Metrics Server Nanny #57462

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Automated cherry pick of #57252: Reduce CPU and memory requests for Metrics Server Nanny #57462

merged 1 commit into from
Jan 3, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Dec 20, 2017 •
edited
Loading

Cherry pick of #57252 on release-1.9.

#57252: Reduce CPU and memory requests for Metrics Server Nanny

Release note:

Free up CPU and memory requested but unused by Metrics Server Pod Nanny.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 20, 2017
@kawych kawych closed this Dec 20, 2017
@kawych kawych reopened this Dec 20, 2017
@kawych
Copy link
Contributor Author

kawych commented Dec 21, 2017

/assign @mbohlool
Please approve cherry-pick

@mbohlool
Copy link
Contributor

Please add the release note. otherwise /lgtm

@mbohlool mbohlool removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 22, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 22, 2017
@mbohlool mbohlool added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 27, 2017
@mbohlool
Copy link
Contributor

mbohlool commented Jan 2, 2018

@kawych @piosz @x13n

(cc'ed people from parent PR)

This cherrypick is inactive for 10 days. The deadline for 1.9.1 cherry pick approvals is today. Please add a release note.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 2, 2018
@kawych kawych mentioned this pull request Jan 2, 2018
Merged
@kawych
Copy link
Contributor Author

kawych commented Jan 2, 2018

/assign @x13n

x13n
x13n reviewed Jan 2, 2018
View reviewed changes
cluster/addons/metrics-server/metrics-server-deployment.yaml
@@ -49,8 +49,8 @@ spec:
cpu: 100m
memory: 300Mi
requests:
cpu: 50m
memory: 100Mi
cpu: 5m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is decreasing by too much. How did you choose this number?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, should be ok.

@x13n
Copy link
Member

x13n commented Jan 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kawych, x13n

Associated issue: #57252

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@mbohlool
Copy link
Contributor

mbohlool commented Jan 3, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 2191870 into kubernetes:release-1.9 Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x13n x13n x13n left review comments

Assignees

@DirectXMan12 DirectXMan12

@x13n x13n

@mbohlool mbohlool

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kawych @mbohlool @x13n @k8s-ci-robot @fejta-bot @k8s-github-robot @DirectXMan12 @piosz