Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use old dns-ip mechanism with older cdk-addons. #57403

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Use old dns-ip mechanism with older cdk-addons. #57403

merged 1 commit into from
Dec 19, 2017

Conversation

wwwtyro
Copy link
Contributor

@wwwtyro wwwtyro commented Dec 19, 2017

What this PR does / why we need it: Use old dns-ip mechanism with older cdk-addons.

Release note:

Use old dns-ip mechanism with older cdk-addons.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2017
@marcoceppi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 19, 2017
@Cynerva
Copy link
Contributor

Cynerva commented Dec 19, 2017

/retest
/assign @Cynerva

@Cynerva
Copy link
Contributor

Cynerva commented Dec 19, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, wwwtyro

Associated issue requirement bypassed by: Cynerva

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57400, 57403, 57303). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4db2245 into kubernetes:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcoceppi marcoceppi

@Cynerva Cynerva

@ktsakalozos ktsakalozos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wwwtyro @marcoceppi @Cynerva @k8s-ci-robot @k8s-github-robot @ktsakalozos