Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '/version/' to the system:discovery role, since that's what the spec says. #57368

Merged
merged 3 commits into from
Dec 20, 2017
Merged

Add '/version/' to the system:discovery role, since that's what the spec says. #57368

merged 3 commits into from
Dec 20, 2017

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 19, 2017 •
edited
Loading

See: kubernetes-client/java#153

Add the path '/version/' to the `system:discovery` cluster role.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2017
@brendandburns
Copy link
Contributor Author

Friendly ping to @liggitt I'd like to cherry-pick this into 1.9 once merged, since it is breaking clients.

@brendandburns brendandburns added this to the v1.10 milestone Dec 20, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@liggitt
Copy link
Member

liggitt commented Dec 20, 2017

No objection, but do we actually answer subpaths?

@liggitt
Copy link
Member

liggitt commented Dec 20, 2017

We should also fix the openapi spec to not put a trailing slash on the version endpoint url

@brendandburns
Copy link
Contributor Author

@liggitt
It does work correctly, so we do answer at least '/version/'

@liggitt
Copy link
Member

liggitt commented Dec 20, 2017

Let's just do /version/, then, and fix openapi ASAP

@brendandburns brendandburns changed the title Add '/version/*' to the system:discovery role, since that's what the spec says. Add '/version/' to the system:discovery role, since that's what the spec says. Dec 20, 2017
@brendandburns
Copy link
Contributor Author

@liggitt switched to /version/

@liggitt
Copy link
Member

liggitt commented Dec 20, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, liggitt

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2017
@brendandburns
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57349, 57368). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c13a2ab into kubernetes:master Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@enj enj

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
7 participants
@brendandburns @k8s-cherrypick-bot @liggitt @k8s-ci-robot @k8s-github-robot @enj @erictune