Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dashboard version to v1.8.3 #57326

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Update dashboard version to v1.8.3 #57326

merged 1 commit into from
Feb 26, 2018
+25 −7

Conversation

floreks
Copy link
Member

@floreks floreks commented Dec 18, 2017 •
edited
Loading

What this PR does / why we need it: Updates dashboard addon to the latest version. Changelog can be found here.

Release note:

Update dashboard version to v1.8.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2017
@floreks
Copy link
Member Author

floreks commented Dec 19, 2017

/assign @jbeda

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2017
@floreks floreks mentioned this pull request Jan 6, 2018
Closed
@floreks floreks changed the title Update dashboard version to v1.8.1 Update dashboard version to v1.8.2 Jan 25, 2018
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2018
@floreks
Copy link
Member Author

floreks commented Jan 28, 2018 •
edited
Loading

Is there a way to check logs of a container that is failing? Without that it is hard to debug.

@liggitt

@joelsmith
Copy link
Contributor

@floreks Would it be possible to update this PR to go straight to a 1.8.3 as per kubernetes/dashboard#2813 ?
Also, I have opened up a related issue, #59354 and I think that your PR here is probably the better place to fix it instead of my PR #59355 updating to 1.8.3.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2018
@floreks floreks changed the title Update dashboard version to v1.8.2 Update dashboard version to v1.8.3 Feb 13, 2018
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2018
liggitt
liggitt reviewed Feb 13, 2018
View reviewed changes
cluster/addons/dashboard/dashboard-rbac.yaml
@@ -7,10 +7,6 @@ metadata:
name: kubernetes-dashboard-minimal
namespace: kube-system
rules:
# Allow Dashboard to create 'kubernetes-dashboard-key-holder' secret.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this change, probably need to add an empty EnsureExists kubernetes-dashboard-key-holder Secret to the secrets.yaml file

liggitt
liggitt reviewed Feb 13, 2018
View reviewed changes
cluster/addons/dashboard/dashboard-controller.yaml
@@ -30,7 +30,7 @@ spec:
priorityClassName: system-cluster-critical
containers:
- name: kubernetes-dashboard
image: k8s.gcr.io/kubernetes-dashboard-amd64:v1.8.0
image: k8s.gcr.io/kubernetes-dashboard-amd64:v1.8.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also change the kubernetes-dashboard-certs volume back to a secret (reverting the dashboard change in
https://github.com/kubernetes/kubernetes/pull/58720/files#diff-7ab88bb7654d97946d6328f11f29d177, now that the dashboard only reads from that mount)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2018
@floreks
Copy link
Member Author

floreks commented Feb 14, 2018 •
edited
Loading

@liggitt Done.

@liggitt
Copy link
Member

liggitt commented Feb 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2018
@floreks
Copy link
Member Author

floreks commented Feb 15, 2018 •
edited
Loading

PTAL @jbeda @zmerlynn

@liggitt
Copy link
Member

liggitt commented Feb 23, 2018

needs squashing
/assign @mikedanese

@liggitt liggitt mentioned this pull request Feb 23, 2018
Merged
@mikedanese
Copy link
Member

mikedanese commented Feb 23, 2018 •
edited
Loading

/approve
/hold

Please cleanup history.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2018
@floreks
Copy link
Member Author

floreks commented Feb 26, 2018

@mikedanese rebased and squashed the commits.

@joelsmith
Copy link
Contributor

/hold cancel
Removing hold since this PR is squashed now. The failing pull-kubernetes-e2e-gke test is currently not marked required and is failing across the vast majority of PRs. So now this PR just needs a lgtm. Sorry that I don't have enough background in this area to provide a review.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2018
@floreks
Copy link
Member Author

floreks commented Feb 26, 2018

@liggitt could you take a look?

@liggitt
Copy link
Member

liggitt commented Feb 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 26, 2018 •
edited
Loading

@floreks: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 85a537c link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelsmith
Copy link
Contributor

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c19f8fc into kubernetes:master Feb 26, 2018
@floreks floreks deleted the update-dashboard branch February 26, 2018 17:55
@joelsmith joelsmith mentioned this pull request Feb 27, 2018
Merged
@liggitt liggitt mentioned this pull request Feb 27, 2018
Closed
k8s-github-robot pushed a commit that referenced this pull request Mar 1, 2018
Merge pull request #60515 from joelsmith/automated-cherry-pick-of-#58…
ed7147f 
…720-#57326-#60342-upstream-release-1.8

Automatic merge from submit-queue.

[1.8] Automated cherry pick of #58720 #57326 #60342

Cherry pick of #58720 #57326 #60342 on release-1.8.

#58720: Ensure that the runtime mounts RO volumes read-only
#57326: Update Dashboard version to v1.8.3
#60342: Fix nested volume mounts for read-only API data volumes

Note for reviewers:
The Dashboard update is necessary because previous versions of the Dashboard attempted to write to the secret volume on startup, and so the read-only secret volume change prevented the Dashboard from starting. 

```release-note
Update dashboard version to v1.8.3

Containers now mount secret, configMap, downwardAPI and projected volumes read-only. Previously,
container modifications to files in these types of volumes were temporary and reverted by the kubelet
during volume sync. Until version 1.11, setting the feature gate ReadOnlyAPIDataVolumes=false will
preserve the old behavior.
```
k8s-github-robot pushed a commit that referenced this pull request Mar 1, 2018
Merge pull request #60258 from joelsmith/automated-cherry-pick-of-#58…
3a9f962 
…720-upstream-release-1.9

Automatic merge from submit-queue.

[1.9] Automated cherry pick of #58720 #57326 #60342

Cherry pick of #58720 #57326 #60342 on release-1.9.

#58720: Ensure that the runtime mounts RO volumes read-only
#57326: Update Dashboard version to v1.8.3
#60342: Fix nested volume mounts for read-only API data volumes

Note for reviewers:
The Dashboard update is necessary because previous versions of the Dashboard attempted to write to the secret volume on startup, and so the read-only secret volume change prevented the Dashboard from starting. 

```release-note
Changes secret, configMap, downwardAPI and projected volumes to mount read-only, instead of allowing applications to write data and then reverting it automatically. Until version 1.11, setting the feature gate ReadOnlyAPIDataVolumes=false will preserve the old behavior. Updates dashboard version to v1.8.3 to avoid writing to read-only locations.
```
@liggitt liggitt mentioned this pull request Mar 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@jbeda jbeda

@liggitt liggitt

@mikedanese mikedanese

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@floreks @joelsmith @liggitt @mikedanese @k8s-ci-robot @k8s-github-robot @jbeda @zmerlynn