Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #56921: enable flexvolume on Windows #57306

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Automated cherry pick of #56921: enable flexvolume on Windows #57306

merged 1 commit into from
Jan 3, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 18, 2017 •
edited
Loading

Cherry pick of #56921 on release-1.9.

#56921: enable flexvolume on Windows

Release note:

enable flexvolume on Windows node

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2017
@andyzhangx
Copy link
Member Author

/assign @brendandburns

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 18, 2017
@brendandburns
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, brendandburns

Associated issue: #56921

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2017
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 29, 2017
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-verify

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-bazel-test

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@mbohlool
Copy link
Contributor

mbohlool commented Jan 2, 2018

@andyzhangx @brendandburns The deadline for 1.9.1 cherrypicks is today and tests are failing for this PR. Can you guys please take a look?

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-bazel-test

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-verify

@andyzhangx
Copy link
Member Author

@mbohlool Test case failure is due to New Year issue, there are some PRs fixing this issue:
e.g.
#57735
#57737

I0102 02:47:17.278] -Copyright 2017 The Kubernetes Authors.
I0102 02:47:17.278] +Copyright 2018 The Kubernetes Authors.

Can this cherry-pick still catch this v1.9.1? Thanks.

@brendandburns
Copy link
Contributor

/retest

@mbohlool I assume that we will hold the release for this since it was due to an automation failure?

@jdumars jdumars added this to the v1.9 milestone Jan 2, 2018
@jdumars jdumars added kind/bug Categorizes issue or PR as related to a bug. status/approved-for-milestone priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jan 2, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@andyzhangx @brendandburns

Pull Request Labels
  • sig/azure sig/windows: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@mbohlool
Copy link
Contributor

mbohlool commented Jan 2, 2018

@mbohlool I assume that we will hold the release for this since it was due to an automation failure?

As long as we get this today, we are on schedule. Let see the result of new tests runs and we proceed from there.

@brendandburns
Copy link
Contributor

@mbohlool looks like we need a cherry pick of #57735 into the 1.9 release branch. Is someone handling this?

If not, I will send a separate CP...

@mbohlool
Copy link
Contributor

mbohlool commented Jan 2, 2018

done #57767

I will kick off all tests when that is merged.

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 2, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit d15333e into kubernetes:release-1.9 Jan 3, 2018
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#56921-upstream-release-1.9 branch May 8, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
8 participants
@andyzhangx @brendandburns @k8s-ci-robot @mbohlool @k8s-github-robot @fejta-bot @k8s-cherrypick-bot @jdumars