Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce CPU and memory requests for Metrics Server Nanny #57252

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Reduce CPU and memory requests for Metrics Server Nanny #57252

merged 1 commit into from
Dec 20, 2017

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Dec 15, 2017 •
edited
Loading

What this PR does / why we need it:
Metrics Server Nanny is a sidecar container that performs small computations every 5 minutes to scale Metrics Server resource requirements when cluster size changes. This change reduces the CPU and memory requests to free up unused resource.

Release note:

Free up CPU and memory requested but unused by Metrics Server Pod Nanny.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2017
@kawych
Copy link
Contributor Author

kawych commented Dec 15, 2017

/assign @piosz

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2017
@kawych
Copy link
Contributor Author

kawych commented Dec 15, 2017

/unassign @DirectXMan12

@kawych
Copy link
Contributor Author

kawych commented Dec 15, 2017

/retest

2 similar comments
@kawych
Copy link
Contributor Author

kawych commented Dec 15, 2017

/retest

@kawych
Copy link
Contributor Author

kawych commented Dec 18, 2017

/retest

@kawych kawych changed the title Reduce CPU request for Metrics Server Nanny Reduce CPU and memory requests for Metrics Server Nanny Dec 18, 2017
@kawych
Copy link
Contributor Author

kawych commented Dec 19, 2017

/assign @x13n
/assign @mikedanese

@kawych
Copy link
Contributor Author

kawych commented Dec 19, 2017

/unassign @mikedanese
/assign @DirectXMan12

@x13n
Copy link
Member

x13n commented Dec 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2017
@piosz
Copy link
Member

piosz commented Dec 19, 2017

50MB of memory seems to be too few for 1000 nodes cluster.

@wojtek-t how much memory do we need to list thousands of nodes?

@piosz piosz assigned wojtek-t and unassigned DirectXMan12 Dec 20, 2017
@piosz
Copy link
Member

piosz commented Dec 20, 2017

/lgtm
please wait for @wojtek-t to confirm that the numbers make sense.

@kawych
Copy link
Contributor Author

kawych commented Dec 20, 2017

Talked offline with Wojciech offline. A single node requires several kilobytes, so for storing 1k nodes several megabytes is enough. I've checked that on 1k node nanny consumes up to ~35MB, which sounds reasonable given that there are other sources of memory usage, binary overhead etc. 50Mi looks like a safe request.

@piosz
Copy link
Member

piosz commented Dec 20, 2017

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, piosz, x13n

Associated issue requirement bypassed by: piosz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57252, 57168). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit dd9bca8 into kubernetes:master Dec 20, 2017
@kawych kawych mentioned this pull request Dec 20, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 3, 2018
Merge pull request #57462 from kawych/automated-cherry-pick-of-#57252…
2191870 
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #57252: Reduce CPU and memory requests for Metrics Server Nanny

Cherry pick of #57252 on release-1.9.

#57252: Reduce CPU and memory requests for Metrics Server Nanny

**Release note**:
```release-note
Free up CPU and memory requested but unused by Metrics Server Pod Nanny.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@x13n x13n

@wojtek-t wojtek-t

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kawych @x13n @piosz @k8s-ci-robot @k8s-github-robot @DirectXMan12 @mikedanese @wojtek-t