Running node selector predicate on kubelet. #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dchen1107 |
|
Feel free to reassign to load balance. |
| @@ -94,3 +98,14 @@ func (c *nodes) Update(minion *api.Node) (*api.Node, error) { | |||
| err := c.r.Put().Resource(c.resourceName()).Name(minion.Name).Body(minion).Do().Into(result) | |||
| return result, err | |||
| } | |||
|
|
|||
| func (c *nodes) Watch(label labels.Selector, field fields.Selector, resourceVersion string) (watch.Interface, error) { | |||
There was a problem hiding this comment.
Add documentation for public method.
|
LGTM mod nit |
Added checking on kubelet if scheduled pods have matching node selector. This is the last step to fix kubernetes#5207.
jszczepkowski
force-pushed
the
kubelet-nodesel
branch
from
d374f03
to
34a8a3a
Compare
|
Comments applied, e2e tests pass. |
|
Thanks Jerzy. LGTM |
saad-ali
added a commit
that referenced
this pull request
Mar 23, 2015
Running node selector predicate on kubelet.
dchen1107
added a commit
to dchen1107/kubernetes-1
that referenced
this pull request
Mar 24, 2015
jayunit100
pushed a commit
to jayunit100/kubernetes
that referenced
this pull request
Mar 26, 2015
akram
pushed a commit
to akram/kubernetes
that referenced
this pull request
Apr 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checking on kubelet if scheduled pods have matching node selector. This is the last step to fix #5207.