Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make kube-dns addon optional #57113

Merged
merged 1 commit into from
Dec 17, 2017
Merged

make kube-dns addon optional #57113

merged 1 commit into from
Dec 17, 2017

Conversation

wwwtyro
Copy link
Contributor

@wwwtyro wwwtyro commented Dec 12, 2017

What this PR does / why we need it: Makes the kube-dns addon optional so that users can deploy their own DNS solution.

Release note:

Makes the kube-dns addon optional so that users can deploy their own DNS solution.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2017
@wwwtyro wwwtyro mentioned this pull request Dec 12, 2017
Merged
@wwwtyro wwwtyro mentioned this pull request Dec 12, 2017
Merged
@dims
Copy link
Member

dims commented Dec 13, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 13, 2017
@ktsakalozos
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2017
@ktsakalozos
Copy link
Contributor

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ktsakalozos, wwwtyro

Associated issue requirement bypassed by: ktsakalozos

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56676, 57050, 54881, 56822, 57113). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3492467 into kubernetes:master Dec 17, 2017
@mooneygr mooneygr mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cynerva Cynerva

@ktsakalozos ktsakalozos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wwwtyro @dims @ktsakalozos @k8s-ci-robot @k8s-github-robot @Cynerva