Refactor pkg/kubelet/config/file_test.go #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
force-pushed
the
refactor_file_test
branch
from
f7bbe21 to
3c6105b
Compare
|
Can rebase now that #5704 is in :) |
wojtek-t
force-pushed
the
refactor_file_test
branch
from
3c6105b to
5d51318
Compare
|
Rebased. |
| Namespace: kubelet.NamespaceDefault, | ||
| SelfLink: "/api/v1beta2/pods/12345-" + hostname + "?namespace=default", | ||
| }, | ||
| Spec: api.PodSpec{Containers: []api.Container{{Image: "test/image"}}}, |
There was a problem hiding this comment.
Shouldn't these have the container name and imagePullPolicy? I'm a bit confused the tests pass. We do include these in http_test.go
There was a problem hiding this comment.
As you noted below - it's because DeepDerivative.
|
Looks good overall, just some questions. |
|
LGTM |
wojtek-t
force-pushed
the
refactor_file_test
branch
from
5d51318 to
9c4ef28
Compare
|
PTAL |
|
LGTM, thanks @wojtek-t! |
vmarmol
added a commit
that referenced
this pull request
Mar 20, 2015
Refactor pkg/kubelet/config/file_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do NOT merge until #5704 is merged.
This is a followup from #5704
Also - this PR is built on top of #5704, thus only the last commit is unique (and should be reviewed).
@vmarmol @yujuhong