Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAMLDecoder Read behaviour #57000

Merged
merged 2 commits into from
Dec 18, 2017
Merged

Fix YAMLDecoder Read behaviour #57000

merged 2 commits into from
Dec 18, 2017

Conversation

sel
Copy link
Contributor

@sel sel commented Dec 10, 2017

What this PR does / why we need it:

Makes YAMLDecoder adhere to the Read contract by returning the number of bytes
read.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56999

Special notes for your reviewer:

Release note:

YAMLDecoder Read now returns the number of bytes read

@sel
Fix YAMLDecoder Read behaviour
86d02ac 
Make it adhere to the Read contract by returning the number of bytes
read.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2017
@sel
Copy link
Contributor Author

sel commented Dec 10, 2017

/assign @deads2k

sel added a commit to sel/update-docker-tag that referenced this pull request Dec 10, 2017
@sel
Add support for multi-document YAML files
67ad4fa 
Depends-On: kubernetes/kubernetes#57000
@sel sel mentioned this pull request Dec 10, 2017
Merged
sel added a commit to sel/update-docker-tag that referenced this pull request Dec 10, 2017
@sel
Add support for multi-document YAML files
7f84f76 
Depends-On: kubernetes/kubernetes#57000
sel added a commit to sel/update-docker-tag that referenced this pull request Dec 10, 2017
@sel
Add support for multi-document YAML files
e595416 
Depends-On: kubernetes/kubernetes#57000
@danielqsj
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@danielqsj: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Dec 11, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 11, 2017
@sel
Copy link
Contributor Author

sel commented Dec 12, 2017

The test failure seems unrelated to this change (segfault in the JVM while building the docs)
/retest

@sel
Copy link
Contributor Author

sel commented Dec 12, 2017

/retest

@sel
Copy link
Contributor Author

sel commented Dec 12, 2017

Thanks for the review, @mikedanese.
PTAL and let me know if I should squash the commits.

@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2017
@sel
Copy link
Contributor Author

sel commented Dec 12, 2017

/test pull-kubernetes-e2e-gce

@deads2k
Copy link
Contributor

deads2k commented Dec 18, 2017

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, deads2k, mikedanese, sel

Associated issue: #56999

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57324, 56931, 57000, 57150, 56965). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7e8dd6c into kubernetes:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese mikedanese left review comments

Assignees

@liggitt liggitt

@mikedanese mikedanese

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAMLDecoder Read function always returns n=0 bytes
8 participants
@sel @danielqsj @k8s-ci-robot @dims @mikedanese @deads2k @k8s-github-robot @liggitt