Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AWS attach/detach operations faster #56974

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Make AWS attach/detach operations faster #56974

merged 1 commit into from
Feb 9, 2018

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Dec 8, 2017 •
edited
Loading

Most attach/detach operations on AWS finish within 1-4seconds.
By using a shorter time interval and higher exponetial
factor we can shorten time taken for attach and detach to complete.

After this change retry interval looks like:

[1, 1.8, 3.24, 5.832000000000001, 10.4976]

Before it was:

[10, 12.0, 14.399999999999999, 17.279999999999998]

/sig aws

AWS: Make attach/detach operations faster. from 10-12s to 2-6s

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/aws labels Dec 8, 2017
@gnufied
Make AWS attach/detach operations faster
0e6a541 
Most attach/detach operations on AWS finish within 1-4seconds.
By using a shorter time interval and higher exponetial
factor  we can shorten time taken for attach and detach to complete.
@gnufied gnufied force-pushed the speed-up-attach-detach branch from 3061d33 to 0e6a541 Compare December 8, 2017 20:29
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 8, 2017
@gnufied
Copy link
Member Author

gnufied commented Dec 8, 2017

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 8, 2017
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2017
@gnufied
Copy link
Member Author

gnufied commented Dec 14, 2017

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce

@gnufied
Copy link
Member Author

gnufied commented Dec 15, 2017

@justinsb can you have a look at this PR? it kinda helps in low latency situations. I measured metrics before and after this PR and now I can see most attach operations completing with 5s.

@justinsb
Copy link
Member

/lgtm

@jsafrane
Copy link
Member

Umm, what's the status of this PR? It misses /approve no-issue.

/retest

@justinsb
Copy link
Member

justinsb commented Feb 9, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 30f54b4 into kubernetes:master Feb 9, 2018
@gnufied gnufied mentioned this pull request Apr 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gnufied @jsafrane @justinsb @k8s-ci-robot @fejta-bot @k8s-github-robot