Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LimitRange ignores objects previously marked for deletion #56971

Merged
merged 1 commit into from
Jan 4, 2018
Merged

LimitRange ignores objects previously marked for deletion #56971

merged 1 commit into from
Jan 4, 2018

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Dec 8, 2017 •
edited
Loading

What this PR does / why we need it:
A LimitRange added to a namespace after it has pods can prevent terminating pods from being deleted if they do not conform to the min/max criteria.

xref https://bugzilla.redhat.com/show_bug.cgi?id=1509309

Fixes #57201

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2017
@dixudx
Copy link
Member

dixudx commented Dec 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2017
@derekwaynecarr
Copy link
Member Author

bot /approve this as i gave an issue.

@liggitt
Copy link
Member

liggitt commented Dec 16, 2017

Why is limitrange paying attention to updates?

@deads2k
Copy link
Contributor

deads2k commented Jan 2, 2018

Why is limitrange paying attention to updates?

If memory serves, you can update the amount of request resources on pods, rigth?

@liggitt
Copy link
Member

liggitt commented Jan 2, 2018

If memory serves, you can update the amount of request resources on pods, rigth?

no... only image, activeDeadlineSeconds, and tolerations

@sjenning
Copy link
Contributor

sjenning commented Jan 3, 2018

/retest

@sjenning sjenning mentioned this pull request Jan 3, 2018
Merged
@derekwaynecarr
Copy link
Member Author

i think it was historical w/ pvc capacity, but memory escapes me.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dixudx

Associated issue: #57201

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cb6b88f into kubernetes:master Jan 4, 2018
openshift-merge-robot added a commit to openshift/origin that referenced this pull request Jan 5, 2018
@openshift-merge-robot
Merge pull request #17978 from sjenning/pick-56971
5223c66 
Automatic merge from submit-queue.

UPSTREAM: 56971: LimitRange ignores objects previously marked for deletion

kubernetes/kubernetes#56971

xref https://bugzilla.redhat.com/show_bug.cgi?id=1509309

@derekwaynecarr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dixudx dixudx

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@derekwaynecarr @dixudx @liggitt @deads2k @sjenning @k8s-ci-robot @k8s-github-robot