-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ExternalTrafficLocalOnly from kube_feature gate #56948
Remove ExternalTrafficLocalOnly from kube_feature gate #56948
Conversation
/assign smarterclayton |
proxier part changes looks good to me. /lgtm |
/retest |
2 similar comments
/retest |
/retest |
/test all Tests are more than 96 hours old. Re-running tests. |
/retest |
/test all Tests are more than 96 hours old. Re-running tests. |
3 similar comments
/test all Tests are more than 96 hours old. Re-running tests. |
/test all Tests are more than 96 hours old. Re-running tests. |
/test all Tests are more than 96 hours old. Re-running tests. |
/assign @thockin |
/test all Tests are more than 96 hours old. Re-running tests. |
1 similar comment
/test all Tests are more than 96 hours old. Re-running tests. |
/retest |
/test all Tests are more than 96 hours old. Re-running tests. |
1 similar comment
/test all Tests are more than 96 hours old. Re-running tests. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1093782566, MrHohn, thockin Associated issue: #46404 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all Tests are more than 96 hours old. Re-running tests. |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it*:
This PR is for v1.10.
External Source IP Preservation (ESIPP) had been promoted to GA since 1.7. Following the proposal on #46404 (comment), we should be able to remove it from feature gate now.
Added release note to announce this.
Also ref the previous attempt: #45857.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #56645
Special notes for your reviewer:
Release note: