Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExternalTrafficLocalOnly from kube_feature gate #56948

Merged

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Dec 8, 2017

What this PR does / why we need it*:
This PR is for v1.10.

External Source IP Preservation (ESIPP) had been promoted to GA since 1.7. Following the proposal on #46404 (comment), we should be able to remove it from feature gate now.

Added release note to announce this.

Also ref the previous attempt: #45857.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56645

Special notes for your reviewer:

Release note:

"ExternalTrafficLocalOnly" has been removed from feature gate. It has been a GA feature since v1.7.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2017
@juanvallejo
Copy link
Contributor

/assign smarterclayton

@m1093782566
Copy link
Contributor

proxier part changes looks good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2017
@m1093782566
Copy link
Contributor

/retest

2 similar comments
@m1093782566
Copy link
Contributor

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Jan 8, 2018

/retest

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@BenTheElder
Copy link
Member

/retest

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

3 similar comments
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@MrHohn
Copy link
Member Author

MrHohn commented Jan 12, 2018

/assign @thockin
/unassign @smarterclayton

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

1 similar comment
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@MrHohn
Copy link
Member Author

MrHohn commented Jan 16, 2018

/retest

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

1 similar comment
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@MrHohn
Copy link
Member Author

MrHohn commented Jan 17, 2018

/retest

@thockin
Copy link
Member

thockin commented Jan 19, 2018

/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, MrHohn, thockin

Associated issue: #46404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2018
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3256546 into kubernetes:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLEANUP] Remove left over feature gate checks for ESIPP
9 participants