Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make audit webhook backend configurable in startup scripts #56890

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Make audit webhook backend configurable in startup scripts #56890

merged 1 commit into from
Dec 7, 2017

Conversation

crassirostris
Copy link

@crassirostris crassirostris commented Dec 6, 2017 •
edited
Loading

Fixes #54551

This PR makes it possible to configure some audit webhook parameters from startup scripts

/cc @piosz @mikedanese @roberthbailey

Audit webhook backend is now configurable via environment variables form the startup scripts.

Make audit webhook backend configurable in startup scripts
fe0577e 
Signed-off-by: Mik Vyatskov <vmik@google.com>
@crassirostris crassirostris added area/audit kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/auth Categorizes an issue or PR as relevant to SIG Auth. status/approved-for-milestone labels Dec 6, 2017
@crassirostris crassirostris added this to the v1.9 milestone Dec 6, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2017
@crassirostris crassirostris mentioned this pull request Dec 6, 2017
Closed
14 tasks
@crassirostris crassirostris added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Dec 6, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 6, 2017
@piosz
Copy link
Member

piosz commented Dec 6, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2017
@wojtek-t wojtek-t self-assigned this Dec 7, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Dec 7, 2017

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz, wojtek-t

Associated issue: #54551

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@crassirostris @mikedanese @piosz @roberthbailey @wojtek-t

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/auth sig/instrumentation: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@crassirostris
Copy link
Author

/retest

@crassirostris
Copy link
Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4788c50 into kubernetes:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@piosz piosz Awaiting requested review from piosz

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@mikedanese mikedanese

@roberthbailey roberthbailey

@wojtek-t wojtek-t

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
7 participants
@crassirostris @piosz @wojtek-t @k8s-ci-robot @k8s-github-robot @mikedanese @roberthbailey