Kubelet: per-pod workers should avoid grabbing the pod array lock #5685
+34
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume I was summoned by accident. |
|
Yes, my apology. I meant to cc/ @fgrzadkowski I don't know a good way to unsubscribe from a github issue once you've mentioned, so apologize again for the future noise... |
| if !found { | ||
| return api.PodStatus{}, fmt.Errorf("Couldn't find spec for pod %s", podFullName) | ||
| return api.PodStatus{}, fmt.Errorf("Couldn't find pod %s", podFullName) |
There was a problem hiding this comment.
nit: I know you didn't change it but: errors should start with lowercase and can qe use %q instead of %s? I find it helps in cases when whitespace and empty strings are concerned.
There was a problem hiding this comment.
Agreed. Changed this and more.
|
LGTM, just a minor nit |
Per-pod worker syncs the pod and container status, and write the pod status in the pod status cache. Given that it already owns a copy of the pod, it can bypass the additional pod lookup step completely. This change adds a new generatePodStatusByPod() method to achieve this. In general, per-pod worker should avoid accessing the internal pod array completely, as this would may lead to high contention. This change also changes the return type of GetPodByFullName to reflect the name, and consolidates GetPodByFullName() and GetPodByName().
|
Addressed the nit. Thanks! |
|
LGTM, thanks @yujuhong and thanks for fixing the nits! |
vmarmol
added a commit
that referenced
this pull request
Mar 20, 2015
Kubelet: per-pod workers should avoid grabbing the pod array lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per-pod worker syncs the pod and container status, and write the pod status in
the pod status cache. Given that it already owns a copy of the pod, it can
bypass the additional pod lookup step completely. This change adds a new
generatePodStatusByPod() method to achieve this. In general, per-pod worker
should avoid accessing the internal pod array completely, as this would may
lead to high contention.
This change also changes the return type of GetPodByFullName to reflect the
name, and consolidates GetPodByFullName() and GetPodByName().