Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick #53647 #56835

Merged
merged 1 commit into from
Dec 6, 2017
Merged

cherry-pick #53647 #56835

merged 1 commit into from
Dec 6, 2017

Conversation

wenlxie
Copy link
Contributor

@wenlxie wenlxie commented Dec 5, 2017 •
edited by jpbetz
Loading

cherry-pick #53647

Release note:

scheduler: Fix issue were a new pod with affinity gets stuck at `creating` because the node had been deleted but the pod still exists.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 5, 2017
@k82cn
Copy link
Member

k82cn commented Dec 5, 2017

I'm ok with that. Please ping 1.8 release manger to get approval :).

@wenlxie
Copy link
Contributor Author

wenlxie commented Dec 5, 2017

thanks @k82cn
@jpbetz This is a fix for kube-scheduler, pod can't get scheduled when node get deleted but pod are still exists. Can we get this merged to k8s 1.8?

@dims
Copy link
Member

dims commented Dec 5, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2017
@jpbetz jpbetz added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 6, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: wenlxie

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@kubernetes kubernetes deleted a comment from k8s-github-robot Dec 6, 2017
@jpbetz
Copy link
Contributor

jpbetz commented Dec 6, 2017 •
edited
Loading

@wenlxie Approved. Please add a release note. The bot will not merge this without one.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 6, 2017
@wenlxie
Copy link
Contributor Author

wenlxie commented Dec 6, 2017

@jpbetz Thanks, release-note added.

@jpbetz jpbetz merged commit 136cdce into kubernetes:release-1.8 Dec 6, 2017
@wenlxie wenlxie deleted the githubupstream.release-1.8.fixinterpodantiaffinity branch October 24, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jayunit100 jayunit100

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wenlxie @k82cn @dims @k8s-ci-robot @jpbetz @jayunit100 @k8s-github-robot