-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add yaml-quote for GCE_GLBC_IMAGE #56824
Conversation
how did this work without yaml quote? |
/kind bug |
/priority critical-urgent |
/approve no-issue |
/retest |
Because the consumer does not care so far: https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L2221 |
/test pull-kubernetes-e2e-gce |
This PR is still pending approval and does not appear to be a blocker. As such, it is being removed from 1.9. If this is in error (because it does actually represent critical breakage) please escalate the priority and return it to the milestone (and approve it) within the next 24 hours. Thanks! /priority important-soon |
@eparis @jbeda @mikedanese @roberthbailey @zmerlynn - we need of of you to hit |
@mikedanese looks like this needs your approval |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan, zmerlynn Associated issue requirement bypassed by: zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/remove-priority important-soon |
[MILESTONENOTIFIER] Milestone Pull Request Current Note: This pull request is marked as Example update:
Pull Request Labels
|
/retest Review the full test history for this PR. |
/test all [submit-queue is verifying that this PR is safe to merge] |
@freehan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 56599, 56824, 56918, 56967, 56959). If you want to cherry-pick this change to another branch, please follow the instructions here. |
fix a bug that
GCE_GLBC_IMAGE
was not processed by yaml-quote.