Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yaml-quote for GCE_GLBC_IMAGE #56824

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Dec 5, 2017

fix a bug that GCE_GLBC_IMAGE was not processed by yaml-quote.

NONE

@freehan freehan added this to the v1.9 milestone Dec 5, 2017
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2017
@bowei
Copy link
Member

bowei commented Dec 5, 2017

how did this work without yaml quote?

@bowei
Copy link
Member

bowei commented Dec 5, 2017

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 5, 2017
@bowei
Copy link
Member

bowei commented Dec 5, 2017

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 5, 2017
@bowei
Copy link
Member

bowei commented Dec 5, 2017

/approve no-issue

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Dec 5, 2017
@dims
Copy link
Member

dims commented Dec 5, 2017

/retest

@freehan
Copy link
Contributor Author

freehan commented Dec 5, 2017

how did this work without yaml quote?

Because the consumer does not care so far: https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L2221

@dims
Copy link
Member

dims commented Dec 11, 2017

/test pull-kubernetes-e2e-gce

@jberkus
Copy link

jberkus commented Dec 11, 2017

This PR is still pending approval and does not appear to be a blocker. As such, it is being removed from 1.9. If this is in error (because it does actually represent critical breakage) please escalate the priority and return it to the milestone (and approve it) within the next 24 hours. Thanks!

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 11, 2017
@dims
Copy link
Member

dims commented Dec 11, 2017

@eparis @jbeda @mikedanese @roberthbailey @zmerlynn - we need of of you to hit /approve no-issue for this one today or looks like it will be dropped from 1.9 per release team

@bowei
Copy link
Member

bowei commented Dec 11, 2017

@mikedanese looks like this needs your approval

@zmerlynn
Copy link
Member

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, freehan, zmerlynn

Associated issue requirement bypassed by: zmerlynn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@kubernetes kubernetes deleted a comment from k8s-github-robot Dec 11, 2017
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2017
@jberkus
Copy link

jberkus commented Dec 11, 2017

/remove-priority important-soon

@k8s-ci-robot k8s-ci-robot removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 11, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@bowei @freehan

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/network: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 12, 2017

@freehan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 8d2f9fe link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56599, 56824, 56918, 56967, 56959). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d001a74 into kubernetes:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants