Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #390 #56726

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Fix issue #390 #56726

merged 1 commit into from
Dec 16, 2017

Conversation

shaominchen
Copy link

What this PR does / why we need it:
When VM node is removed from vSphere Inventory, the corresponding Kubernetes node is unregistered and removed from registeredNodes cache in nodemanager. However, it is not removed from the other node info cache in nodemanager. The fix is to update the other cache accordingly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes vmware-archive#390

Special notes for your reviewer:
Internally review PR here: vmware-archive#402

Release note:

NONE

Testing Done:

  1. Removed the node VM from vSphere inventory.
  2. Create storageclass and pvc to provision volume dynamically

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2017
@rjog
Copy link

rjog commented Dec 2, 2017

lgtm

@jhorwit2
Copy link
Contributor

jhorwit2 commented Dec 2, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2017
@jsafrane
Copy link
Member

jsafrane commented Dec 4, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2017
@jsafrane
Copy link
Member

jsafrane commented Dec 4, 2017

/assign @BaluDontu, @kerneltime
for approval

@shaominchen
Copy link
Author

/test pull-kubernetes-kubemark-e2e-gce

@BaluDontu
Copy link
Contributor

/approve

@shaominchen
Copy link
Author

/assign @imkin

@jsafrane
Copy link
Member

jsafrane commented Dec 4, 2017

@BaluDontu, you must use /approve no-issue

@BaluDontu
Copy link
Contributor

/approve no-issue

@abrarshivani
Copy link
Contributor

/approve
/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrarshivani, BaluDontu, jsafrane, shaominchen

Associated issue requirement bypassed by: abrarshivani

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56639, 56746, 56715, 56673, 56726). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8475a92 into kubernetes:master Dec 16, 2017
This was referenced Dec 20, 2017
Closed
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 3, 2018
Merge pull request #57482 from vmware/automated-cherry-pick-of-#56648-#…
3a1c944 
…56726-#57053-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #56648 #56726 #57053 upstream release 1.9

Cherry pick of #56648 #56726 #57053 on release 1.9.

#56648: Fix session timeout issue in vSphere Cloud Provider 
#56726: Fix dynamic volume provisioning iussue when VM is removed from inventory
#57053: Compare correct file names for volume detach operation
@shaominchen shaominchen deleted the issue_390 branch January 30, 2018 18:57
@embano1 embano1 mentioned this pull request Aug 22, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsafrane jsafrane

@imkin imkin

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Octopus: Failed to dynamically provision volume if VM is removed from inventory