Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc auth: fix prefix flag plumbing #56175

Merged
merged 1 commit into from
Nov 22, 2017
Merged

oidc auth: fix prefix flag plumbing #56175

merged 1 commit into from
Nov 22, 2017

Conversation

ericchiang
Copy link
Contributor

@ericchiang ericchiang commented Nov 21, 2017 •
edited
Loading

Fixes #56169

Tested this with an full API server against Google. It works now.

:(

cc @kubernetes/sig-auth-bugs

kube-apiserver: fixed --oidc-username-prefix and --oidc-group-prefix flags which previously weren't correctly enabled

/assign @liggitt @deads2k

Probably worth a cherry pick.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 21, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2017
@ericchiang
Copy link
Contributor Author

Flaking on #56166

/test pull-kubernetes-bazel-test

@liggitt
Copy link
Member

liggitt commented Nov 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2017
@liggitt liggitt added this to the v1.9 milestone Nov 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericchiang, liggitt

Associated issue: 56169

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. milestone/incomplete-labels labels Nov 22, 2017
@liggitt liggitt added cherrypick-candidate priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 22, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Needs Attention

@deads2k @ericchiang @liggitt @kubernetes/sig-auth-misc

Action required: During code slush, pull requests in the milestone should be in progress.
If this pull request is not being actively worked on, please remove it from the milestone.
If it is being worked on, please add the status/in-progress label so it can be tracked with other in-flight pull requests.

Note: If this pull request is not resolved or labeled as priority/critical-urgent by Wed, Nov 22 it will be moved out of the v1.9 milestone.

Pull Request Labels
  • sig/auth: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51494, 56097, 56072, 56175). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1489d19 into kubernetes:master Nov 22, 2017
@ericchiang ericchiang mentioned this pull request Nov 22, 2017
Merged
@Josh-West-Bose
Copy link

Will this bugfix get backported to 1.8?

@ericchiang
Copy link
Contributor Author

@Josh-West-Bose yes the cherry pick can be tracked here #56229

@ericchiang ericchiang deleted the oidc-fix-prefixing branch November 27, 2017 18:20
k8s-github-robot pushed a commit that referenced this pull request Nov 27, 2017
Merge pull request #56229 from ericchiang/automated-cherry-pick-of-#5…
a846326 
…6175-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #56175

Cherry pick of #56175 on release-1.8.

#56175: oidc auth: fix prefix flag plumbing
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate labels Nov 28, 2017
@liggitt liggitt mentioned this pull request Dec 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/needs-attention priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

OIDC username prefix option is not working
7 participants
@ericchiang @liggitt @k8s-github-robot @Josh-West-Bose @deads2k @wojtek-t @k8s-ci-robot