Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Network end to end test use a test image with a specific tag (and use a debugged image) #5613

Merged
merged 1 commit into from
Mar 18, 2015

Conversation

satnam6502
Copy link
Contributor

Merge after #5612 has merged (which will null out the files Makefile and webserver.go in this PR from the first commit).

@satnam6502 satnam6502 changed the title Make Network end to end test use a test image with a specific tag (and used a debugged image) Make Network end to end test use a test image with a specific tag (and use a debugged image) Mar 18, 2015
@satnam6502
Copy link
Contributor Author

@lavalamp @thockin @ixdy

@ixdy ixdy self-assigned this Mar 18, 2015
@satnam6502 satnam6502 force-pushed the network branch 3 times, most recently from 496daf2 to ecb0238 Compare March 18, 2015 22:46
@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2015
@ixdy
Copy link
Member

ixdy commented Mar 18, 2015

The file diff looks fine, though the list of commits is worrying. Shouldn't there be only one commit here?

@ixdy ixdy removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2015
@satnam6502
Copy link
Contributor Author

Sorry, squashed. Confusion on my part due to this PR being dependent on another one.

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2015
ixdy added a commit that referenced this pull request Mar 18, 2015
Make Network end to end test use a test image with a specific tag (and use a debugged image)
@ixdy ixdy merged commit df710cd into kubernetes:master Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants