Kubelet: simplify the lock acquring pattern #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid holding both podStatusesLock and podLock at the same time.
|
cc/ @vmarmol, @fgrzadkowski |
|
LGTM, thanks @yujuhong! You had mentioned before of trying to merge pod and podStatus into a separate thread-safe object, do you think that's still worthwhile? |
vmarmol
added a commit
that referenced
this pull request
Mar 18, 2015
Kubelet: simplify the lock acquring pattern
|
I think it'd help with code clarity, and it'll prevent people from misusing the objects. If you agree with it, I can file an issue and work on it :) |
|
+1! The deadlock from before shows how easy the misuse is. Feel free to work on it if you have time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid holding both podStatusesLock and podLock at the same time.