-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark example #5602
Spark example #5602
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
@mattf — This is Spark workers using Spark's standalone mode correct? |
@preillyme that's correct |
https://github.com/mattf/docker-spark/blob/master/worker/start.sh <-- i snooped around and found the dockerfiles for this that you're useing :) ... I think you will want you're containers to not tail the logs as the final line, as this would dupe kube into thinking that the actual spark process is running (even though it may have failed, and you're just tailing stale log folders..) Its not a show stopper, but you might want to mention this as a warning in you're README, because if a container fails, it would be confusing for kube |
also, does this work when master_ip != service_ip ? iirc we had that akka issue where the reverse resolution got rejected from master? update Ah, never mind, i see what you're doing , http://mail-archives.apache.org/mod_mbox/incubator-spark-commits/201501.mbox/%3Ced1ca66694004cda980b9f9cfd74379c@git.apache.org%3E . great idea ! |
Hats off to @mattf and Armbrust on the akka trick. |
Tl;DR : Tested breifly on a cluster of 20 nodes, and works...
In any case, its a great patch ! please just add the links to your dockerfiles repo to the README as well !
|
LGTM just need pointers to the Dockerfiles and other sources used in the example! |
@pires i used the docker hub auto build system so that all the build information is trivially discoverable without having to duplicate it in the example. there's no extra effort required and nothing about the build is hidden or concealed. |
@mattf but you could point to your repo in the documentation, much like I did in the |
@pires how's that? |
@mattf nevermind, it's there. Thanks |
@mattf this is great. Can you squash commits? |
I agree with and 👍 what @timothysc said well done @mattf |
mention the spark cluster is standalone add detailed master & worker instructions add method to get master status add links option for master status add links option for worker status add example use of cluster add source location
@cjcullen i had to force it, how's that? generally i dislike losing history. what's the motivation? |
Motivation is just to keep the commit history as clean (readable) as possible on master. This looks great. Thanks. |
@mattf This is great, thanks for making this contribution. I think it would also be great to get documentation on Spark's end about this, maybe linked to from their Cluster Mode Overview. Is that something you've considered or are pursuing? Thanks again for your contributions. |
@ihmccreery i wasn't planning on it. you should feel free to. if you do, ping me and i'll help review the pr. |
No description provided.